Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuous deployment #144

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Continuous deployment #144

merged 5 commits into from
Nov 15, 2023

Conversation

ttoino
Copy link
Member

@ttoino ttoino commented Sep 23, 2023 •
edited
Loading

Closes #107.
Closes #108.

@ttoino ttoino changed the base branch from develop to main September 23, 2023 16:57
This was linked to issues Sep 23, 2023
Automate Firefox release #107
Closed
Automate Chrome release #108
Closed
@ttoino ttoino marked this pull request as ready for review September 23, 2023 17:03
LuisDuarte1
LuisDuarte1 reviewed Sep 23, 2023
View reviewed changes
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! It seems okay, just have some comments below:

.github/workflows/cd.yml Outdated Show resolved Hide resolved
LuisDuarte1
LuisDuarte1 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pedrosilva17
pedrosilva17 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@pedrosilva17 pedrosilva17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 impeccable

@ttoino ttoino merged commit 0055ca1 into main Nov 15, 2023
@ttoino ttoino deleted the ci/cd branch November 15, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrosilva17 pedrosilva17 pedrosilva17 approved these changes

@LuisDuarte1 LuisDuarte1 LuisDuarte1 approved these changes

@thePeras thePeras Awaiting requested review from thePeras

@toni-santos toni-santos Awaiting requested review from toni-santos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate Chrome release Automate Firefox release
3 participants
@ttoino @LuisDuarte1 @pedrosilva17